Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge pull request #78307 from blanky0230/nixos-tuxedo-keyboard #78307

Merged
merged 3 commits into from
Jan 27, 2020
Merged

Merge pull request #78307 from blanky0230/nixos-tuxedo-keyboard #78307

merged 3 commits into from
Jan 27, 2020
+72 −0

Conversation

blanky0230
Copy link
Member

Motivation for this change

Additional hardware-support for another hardware vendor.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

@infinisil this is a replication of #73885. I completely messed up when trying to remove the merge commit 🙄 I'm sorry to bother you... Feel free to close this, if I'd been to noisy :|

Sorry, something went wrong.

@blanky0230 blanky0230 requested a review from infinisil as a code owner January 22, 2020 17:14
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 2.status: merge conflict This PR has merge conflicts with the target branch labels Jan 22, 2020
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Jan 22, 2020
balsoft
balsoft reviewed Jan 24, 2020
View reviewed changes
Copy link
Member

@balsoft balsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thank you very for contributing. It's always nice to have more hardware support.

You have a typo in commit message

tuxedo-keyboar: create and register module for tuxedo-keyboard driver.

@balsoft
Copy link
Member

balsoft commented Jan 24, 2020

@GrahamcOfBorg build tuxedo-keyboard

@blanky0230 blanky0230 requested a review from balsoft January 24, 2020 22:55
@balsoft
Copy link
Member

balsoft commented Jan 24, 2020

@GrahamcOfBorg build tuxedo-keyboard

@blanky0230 I don't have push access if that's what you're asking for.

@blanky0230
Copy link
Member Author

@balsoft Not at all. I didn't mean to bug you. I just thought it'd be sensible to ask again what you thought.

balsoft
balsoft approved these changes Jan 24, 2020
View reviewed changes
Copy link
Member

@balsoft balsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, looks good.

@balsoft
Copy link
Member

balsoft commented Jan 24, 2020

@GrahamcOfBorg build linuxPackages.tuxedo-keyboard

@balsoft
Copy link
Member

balsoft commented Jan 25, 2020

Commit names should be

tuxedo-keyboard: init at 2019-08-26
nixos/tuxedo-keyboard: init module

infinisil
infinisil approved these changes Jan 27, 2020
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looking good!

@infinisil infinisil changed the title Nixos tuxedo keyboard Merge pull request #78307 from blanky0230/nixos-tuxedo-keyboard Jan 27, 2020
@infinisil infinisil merged commit 34f0200 into NixOS:master Jan 27, 2020
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 27, 2020
@infinisil @dtzWill
Merge pull request NixOS#78307 from blanky0230/nixos-tuxedo-keyboard
c37d021 
Nixos tuxedo keyboard

(cherry picked from commit 34f0200)
@blanky0230 blanky0230 deleted the nixos-tuxedo-keyboard branch January 27, 2020 23:57
@blanky0230 blanky0230 mentioned this pull request May 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balsoft balsoft

@infinisil infinisil

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@blanky0230 @balsoft @infinisil