Skip to content

buildRustCrate: support rlib dependency type #78188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 28, 2020
Merged

buildRustCrate: support rlib dependency type #78188

merged 3 commits into from
Jan 28, 2020
+26 −13

Conversation

andir
Copy link
Member

@andir andir commented Jan 21, 2020

Motivation for this change

.rlib files are the primary dependency type of native rust crates. Most of the time they are being built under the lib kind which also produces the .rlib files. Rustc support to build crates explicitly as rlib dependency. For our purposes we can treat them as the very same.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

andir added 3 commits January 21, 2020 17:22
@andir
buildRustCrate: treat rlib crates just like lib crates
d6a8b55 
Both version provide `rlib` files to link against. Previously we would
try to find a matching shared library in the `lib` output.
@andir
buildRustCrateTests: fix some formatting issues
406e0c9
@andir
buildRustCrateTests: add test case for rlib linking
78faab1
@ofborg ofborg bot added 6.topic: rust 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 21, 2020
@andir andir merged commit cd27940 into NixOS:master Jan 28, 2020
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 30, 2020
@andir @dtzWill
Merge pull request NixOS#78188 from andir/buildRustCrate-support-rlib
04d866f 
buildRustCrate: support `rlib` dependency type
(cherry picked from commit cd27940)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: rust 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@andir