buildRustCrate: support rlib dependency type
#78188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both version provide `rlib` files to link against. Previously we would try to find a matching shared library in the `lib` output.
dtzWill
pushed a commit
to dtzWill/nixpkgs
that referenced
this pull request
Jan 30, 2020
buildRustCrate: support `rlib` dependency type (cherry picked from commit cd27940)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
.rlibfiles are the primary dependency type of native rust crates. Most of the time they are being built under thelibkind which also produces the.rlibfiles. Rustc support to build crates explicitly asrlibdependency. For our purposes we can treat them as the very same.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)