rar2fs: init at 1.28.0 #78189
Merged
rar2fs: init at 1.28.0 #78189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraem
force-pushed
the
master
branch
2 times, most recently
from
554d6a7
to
ac80d22
Compare
ofborg
bot
added
6.topic: GNOME
|
Woops. Thought I finally understood git history. Apparently not. |
ofborg
bot
removed
the
6.topic: GNOME
|
Finally managed to build it without the unrar source-code, wasn't used to debugging autoconf scripts anymore.. :o :D @kraem could you test if everything still works as expected? cc: @ehmry as the |
|
@primeos Works perfectly. Thanks! |
This is e.g. required for the rar2fs build [0], which needs at least version.hpp, rar.hpp, dllext.hpp, dll.hpp, and headers5.hpp. At least Gentoo does this as well [1] but most other distributions only install dll.hpp or no header files at all. [0]: NixOS#78189 [1]: https://gitweb.gentoo.org/repo/gentoo.git/tree/app-arch/unrar/unrar-5.8.5.ebuild
primeos
approved these changes
Jan 23, 2020
There was a problem hiding this comment.
LGTM now, thanks for the PR :)
@ehmry I'll merge it tomorrow if you don't have any complaints (just in case I missed something) ;)
Edit: Forgot to mention: nix-review was successful:
6 package were build:
pdfread rar2fs rarcrack sabnzbd unrar zod
dtzWill
pushed a commit
to dtzWill/nixpkgs
that referenced
this pull request
Jan 24, 2020
This is e.g. required for the rar2fs build [0], which needs at least version.hpp, rar.hpp, dllext.hpp, dll.hpp, and headers5.hpp. At least Gentoo does this as well [1] but most other distributions only install dll.hpp or no header files at all. [0]: NixOS#78189 [1]: https://gitweb.gentoo.org/repo/gentoo.git/tree/app-arch/unrar/unrar-5.8.5.ebuild (cherry picked from commit 983f39c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
rar2fsuses fuse to mount rar archives, or directories containing rar archives, and makes the files available as if they were unrar:ed.rar2fs Github
rar2fs web
Things done
Init package at most recent version 1.28.0
Added the unfree license even though
rar2fsis licensed using GPLv3.The source from
RARLABis used during compilation though. The license ofRARLABis free to distribute if only theUnRARsources are used (source). I'm not sure if anything else is used during the compilation ofrar2fs. I'm super new to licenses and if anyone has any idea as to what the situation is here they are very welcome to have a say in this :)Other
This is my first package added so added myself to the maintainers-list. I'm more than happy to receive suggestions for improvement too :)
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)