Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnugrep: 3.3 -> 3.4 #78181

Merged
merged 1 commit into from Feb 6, 2020
Merged

gnugrep: 3.3 -> 3.4 #78181

merged 1 commit into from Feb 6, 2020

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 21, 2020

Motivation for this change

https://savannah.gnu.org/forum/forum.php?forum_id=9640

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Been using since 2020-01-06 (apparently), so at least isn't entirely
broken ;).

@ofborg ofborg bot requested a review from edolstra January 21, 2020 17:00
@tomberek
Copy link
Contributor

Seems to build/work fine (NixOS). But needs more extensive testing.

@dtzWill
Copy link
Member Author

dtzWill commented Jan 26, 2020

Thoughts on what testing should be done first?

@tomberek
Copy link
Contributor

Standard NixOS test suite probably exercises grep well.

@FRidh FRidh added this to WIP in Staging via automation Jan 29, 2020
@FRidh FRidh merged commit b2b5e08 into NixOS:staging Feb 6, 2020
Staging automation moved this from WIP to Done Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 10.rebuild-linux-stdenv
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @tomberek @FRidh