Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/lcd: add support for Logitech LCD #78166

Merged
merged 2 commits into from Aug 5, 2020
Merged

nixos/lcd: add support for Logitech LCD #78166

merged 2 commits into from Aug 5, 2020

Conversation

peterhoeg
Copy link
Member

@peterhoeg peterhoeg commented Jan 21, 2020 •
edited

Motivation for this change

A number of (old) Logitech devices have LCDs built-in and this adds support for them.

There are a number of dependencies which are all contained inside a single file. As the last releases of those dependencies were all more than 10 years ago and the hardware is no longer being produced, I didn't think it was worth it to pollute the the global attribute set.

This all works here but as I don't have all the hardware, it would be great if somebody else could try it out as well.

A few minor things to do:

  • split the package and the module into separate commits
  • write release note
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@peterhoeg
Copy link
Member Author

We want to merge this first: #82944

@lschuermann
Copy link
Member

When trying to build this, my version of the config-write patch had the checksum 0jkrbqvzqrvxr14h5qi17cb4d32caq7vw9kzlz3qwpxdgxjrjvy2. It appears as if the patch function's url is not entirely stable.

@peterhoeg peterhoeg force-pushed the m/logitech_lcd branch 2 times, most recently from dc2a833 to f57282b Compare April 8, 2020 12:50
@peterhoeg peterhoeg mentioned this pull request Apr 8, 2020
Merged
10 tasks
@peterhoeg
Copy link
Member Author

It appears as if the patch function's url is not entirely stable.

Indeed. It's basically pointing at master in a git repository and if somebody changes anything, the checksum will change. This happens quite a lot with patches from Arch. It still beats maintaining it yourself though....

@peterhoeg peterhoeg changed the title nixos/lcd: add support for Logitech LCD [WIP] nixos/lcd: add support for Logitech LCD Aug 4, 2020
@peterhoeg
Copy link
Member Author

This is good to go. Anybody else with some supported equipment?

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/calling-owners-of-logitech-keyboards-and-usb-speakers-with-lcds/8444/1

@peterhoeg peterhoeg merged commit 4d8cc10 into NixOS:master Aug 5, 2020
@peterhoeg peterhoeg deleted the m/logitech_lcd branch August 5, 2020 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: documentation 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peterhoeg @lschuermann @nixos-discourse