Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.nest-asyncio: build without tests #78214

Merged
merged 1 commit into from Jan 21, 2020
Merged

pythonPackages.nest-asyncio: build without tests #78214

merged 1 commit into from Jan 21, 2020

Conversation

drewrisinger
Copy link
Contributor

Motivation for this change

Build fails due to tests on v1.2.1 & old v1.2.0.
This disables the tests to allow this package to build.
There doesn't seem to be an easy fix to allow running tests, b/c
the GitHub repo doesn't have release tags.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions (Ubuntu)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests) N/A
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip". Said "no diff detected, stopping review..."
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Other tests

On master branch: nix-build -A pythonPackages.nest-asyncio: Build fails
On PR branch: same command passes.

@drewrisinger
pythonPackages.nest-asyncio: build without tests
1cb8aac 
Tests fail on v1.2.1 & old v1.2.0.
This disables the tests to allow this package to build.
There doesn't seem to be an easy fix to allow running tests, b/c
the GitHub repo doesn't have release tags.
@ofborg ofborg bot requested a review from costrouc January 21, 2020 21:45
jonringer
jonringer approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

improvement, LGTM. Although true unit tests would be better

[3 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/78214
2 package built:
python37Packages.nest-asyncio python38Packages.nest-asyncio

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python37Packages.nest-asyncio python38Packages.nest-asyncio

@jonringer jonringer merged commit 338c151 into NixOS:master Jan 21, 2020
@drewrisinger drewrisinger deleted the dr-pr-fix-nest_asyncio-tests branch January 21, 2020 23:35
@drewrisinger
Copy link
Contributor Author

drewrisinger commented Jan 21, 2020 •
edited

improvement, LGTM. Although true unit tests would be better

@jonringer agreed, but as stated in comments there's no releases/tags. So I think it's an OK compromise for how little it's used in-tree, vs effort of hand-selecting the proper commit that works.
cc @erdewit

@erdewit erdewit mentioned this pull request Jan 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@drewrisinger @jonringer