Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.vega: build fix #78254

Merged
merged 1 commit into from Jan 22, 2020
Merged

pythonPackages.vega: build fix #78254

merged 1 commit into from Jan 22, 2020

Conversation

arnoldfarkas
Copy link
Contributor

Motivation for this change

vega 2.6 also depends on ipywidgets. The missing dependency caused the build to fail e.g.: https://hydra.nixos.org/build/110453573

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

pythonPackages.vega: build fix
dbdd4ac 
vega 2.6 also depends on ipywidgets
@ofborg ofborg bot requested a review from teh January 22, 2020 08:49
jonringer
jonringer approved these changes Jan 22, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff/commit LGTM
in fact fixes build

[4 built, 29 copied (58.0 MiB), 9.1 MiB DL]
https://github.com/NixOS/nixpkgs/pull/78254
3 package built:
python27Packages.vega python37Packages.vega python38Packages.vega

I upstreamed the proper fix for this: vega/ipyvega#157

@jonringer jonringer merged commit 9588e9c into NixOS:master Jan 22, 2020
@WorldQuantOS WorldQuantOS deleted the wq_vega branch January 22, 2020 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@teh teh Awaiting requested review from teh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arnoldfarkas @jonringer