Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coqPackages.CoLoR: 1.4.0 -> 1.7.0 #78253

Merged
merged 4 commits into from Jan 27, 2020
Merged

coqPackages.CoLoR: 1.4.0 -> 1.7.0 #78253

merged 4 commits into from Jan 27, 2020

Conversation

jpas
Copy link
Contributor

@jpas jpas commented Jan 22, 2020

Motivation for this change

I'm working on a project that requires this package and it is about a year years out of date and the old version no longer states support for Coq 8.6 and 8.7 which are at least 2 minor versions out of date.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jpas
add jpas to maintainers
5a19bf0
@jpas
coqPackages.CoLoR 1.4.0 -> 1.6.0
4339f58 
The package is now developed on GitHub, so fetchurl was replace with
fetchFromGithub.
@vbgl
Copy link
Contributor

vbgl commented Jan 23, 2020

The updated version won’t build with Coq < 8.8. Please either fix the compatibleCoqVersions attribute or keep older versions of CoLoR for older versions of Coq.

@jpas
Copy link
Contributor Author

jpas commented Jan 25, 2020

With this re-factor it should be pretty straight forward to add in CoLoR 1.7.0 for Coq 8.10.

Would a new PR make sense for adding that or should I rename this one and add that version as well?

@vbgl
Copy link
Contributor

vbgl commented Jan 26, 2020

If you don’t mind, please add version 1.7.0 for Coq 8.10 in this very PR. Thanks.

@jpas jpas changed the title coqPackages.CoLoR: 1.4.0 -> 1.6.0 coqPackages.CoLoR: 1.4.0 -> 1.7.0 Jan 26, 2020
@vbgl
Copy link
Contributor

vbgl commented Jan 27, 2020

@GrahamcOfBorg build coqPackages.CoLoR

@vbgl vbgl merged commit e59dcf8 into NixOS:master Jan 27, 2020
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 27, 2020
@vbgl @dtzWill
Merge pull request NixOS#78253 from jpas/CoLoR-1.6.0
3f1c5d5 
coqPackages.CoLoR: 1.4.0 -> 1.7.0

(cherry picked from commit e59dcf8)
@jpas jpas deleted the CoLoR-1.6.0 branch January 27, 2020 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: coq 8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jpas @vbgl @Janik-Haag