Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

steam: use 64-bit libva #78310

Merged
merged 1 commit into from Jan 23, 2020
Merged

steam: use 64-bit libva #78310

merged 1 commit into from Jan 23, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 22, 2020 •
edited

Motivation for this change

looks like steam not only removed the "crash-on-startup-if-32-bit-libva-isn't-present", but also made the 64-bit version required for one of their FTP games, "Dota Underlords"

Confirmed that trying to open the game with any combination of the 32/64 bit versions would cause the game to seize. Only the 64 bit version worked.

Related: #73512

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer requested a review from andir January 22, 2020 18:01
andir
andir approved these changes Jan 23, 2020
View reviewed changes
Copy link
Member

@andir andir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 works for me. We should also backport that change.

@jonringer jonringer merged commit f4b4c66 into NixOS:master Jan 23, 2020
@jonringer jonringer deleted the update-steam branch January 23, 2020 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andir andir andir approved these changes

Assignees
No one assigned
Labels
6.topic: steam 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @andir