Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mockingbirdnest/Principia
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 97dce1eb58de
Choose a base ref
...
head repository: mockingbirdnest/Principia
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 407eade79e3a
Choose a head ref
  • 2 commits
  • 1 file changed
  • 1 contributor

Commits on Jan 22, 2020

  1. Copy the full SHA
    01c6caa View commit details
  2. Merge pull request #2456 from eggrobin/config-constraints

    Do not provide a defaulted reference_radius if no geopotential is present
    eggrobin authored Jan 22, 2020
    Copy the full SHA
    407eade View commit details
Showing with 3 additions and 1 deletion.
  1. +3 −1 ksp_plugin_adapter/config_node_parsers.cs
4 changes: 3 additions & 1 deletion ksp_plugin_adapter/config_node_parsers.cs
Original file line number Diff line number Diff line change
@@ -85,7 +85,9 @@ public static BodyParameters NewKeplerianBodyParameters(CelestialBody body,
(body.angularV + " rad/s"),
reference_radius =
node?.GetAtMostOneValue("reference_radius") ??
(j2 != null || geopotential != null ? body.Radius + " m" : null),
(j2 != null || (geopotential?.Length ?? 0) != 0
? body.Radius + " m"
: null),
j2 = j2,
geopotential = geopotential
};