Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 88235d99a484
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 2d9e51adc37c
Choose a head ref
  • 4 commits
  • 1 file changed
  • 2 contributors

Commits on Jan 18, 2020

  1. nixos/roundcube: do not write passwords to the store nor run php as root 

    If the database is local, use postgres peer authentication.
Otherwise, use a password file.

Leave database initialisation to postgresql.ensure*.
Leave /var/lib/roundcube creation to systemd.
Run php upgrade script as unpriviledged user.
    @symphorien
    symphorien committed Jan 18, 2020
    Copy the full SHA
    52cf727 View commit details
    Browse the repository at this point in the history

  2. nixos/roundcube: don't use the default and insecure des_key 

    The php installer creates a random one, but we bypass it, so we have
to create one ourselves.

This should be backward compatible as encryption is used for session
cookies only: users at the time of the upgrade will be logged out but
nothing more.

https://github.com/roundcube/roundcubemail/blob/259b7fa0650fea9320b38cb17c4e80497acae7a3/config/config.inc.php.sample#L73
    @symphorien
    symphorien committed Jan 18, 2020
    Copy the full SHA
    b6e6bec View commit details
    Browse the repository at this point in the history

  3. nixos/roundcube: provide path to mime.types file 

    fixes this warning:
WARNING: Mimetype to file extension mapping doesn't work properly!
    @symphorien
    symphorien committed Jan 18, 2020
    Copy the full SHA
    b5d692e View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2020

  1. Merge pull request #77532 from symphorien/roundcube 

    nixos/roundcube: security improvements
    @Ma27
    Ma27 committed Jan 22, 2020
    Copy the full SHA
    2d9e51a View commit details
    Browse the repository at this point in the history