Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.ppft: re-enable tests #78209

Merged
merged 1 commit into from Jan 23, 2020
Merged

python3Packages.ppft: re-enable tests #78209

merged 1 commit into from Jan 23, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 21, 2020 •
edited

Motivation for this change

closes #78194

They follow a non-standard testing format, although they try to do parallel compute, which isn't a normal python use case

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
[6 built, 10 copied (4.0 MiB), 1.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/78209
6 package built:
python27Packages.pathos python27Packages.ppft python37Packages.pathos python37Packages.ppft python38Packages.pathos python38Packages.ppft

@jonringer jonringer requested a review from FRidh as a code owner January 21, 2020 20:19
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python27Packages.pathos python27Packages.ppft python37Packages.pathos python37Packages.ppft python38Packages.pathos python38Packages.ppft

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python27Packages.pathos python27Packages.ppft python37Packages.pathos python37Packages.ppft python38Packages.pathos python38Packages.ppft

@jonringer jonringer merged commit c2a3fed into NixOS:master Jan 23, 2020
@jonringer jonringer deleted the reenable-ppft-tests branch February 20, 2020 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ppft tests
1 participant
@jonringer