Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge pull request #78265 from Synthetica9/https-homepages #78265

Merged
merged 1 commit into from Jan 27, 2020
Merged

Merge pull request #78265 from Synthetica9/https-homepages #78265

merged 1 commit into from Jan 27, 2020

Conversation

Synthetica9
Copy link
Member

@Synthetica9 Synthetica9 commented Jan 22, 2020 •
edited

Motivation for this change

According to https://repology.org/repository/nix_unstable/problems, we have a
lot of packages that have http links that redirect to https as their homepage.
This commit updates all these packages to use the https links as their
homepage.

The following script was used to make these updates:


curl https://repology.org/api/v1/repository/nix_unstable/problems \
    | jq '.[] | .problem' -r \
    | rg 'Homepage link "(.+)" is a permanent redirect to "(.+)" and should be updated' --replace 's@$1@$2@' \
    | sort | uniq > script.sed

find -name '*.nix' | xargs -P4 -- sed -f script.sed -i

This should save a few http 301 requests when building and might be safer for our users.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Synthetica9
treewide: fix redirected urls
593e11f 
According to https://repology.org/repository/nix_unstable/problems, we have a
lot of packages that have http links that redirect to https as their homepage.
This commit updates all these packages to use the https links as their
homepage.

The following script was used to make these updates:

```

curl https://repology.org/api/v1/repository/nix_unstable/problems \
    | jq '.[] | .problem' -r \
    | rg 'Homepage link "(.+)" is a permanent redirect to "(.+)" and should be updated' --replace 's@$1@$2@' \
    | sort | uniq > script.sed

find -name '*.nix' | xargs -P4 -- sed -f script.sed -i
```
@Synthetica9
Copy link
Member Author

(This is a draft because I want to see what ofborg says before pinging everyone)

@Synthetica9 Synthetica9 marked this pull request as ready for review January 22, 2020 11:17
This was referenced Jan 23, 2020
Closed
Closed
Closed
@infinisil infinisil changed the title treewide: fix redirected urls Merge pull request #78265 from Synthetica9/https-homepages Jan 27, 2020
@infinisil infinisil merged commit 80a2740 into NixOS:master Jan 27, 2020
@Synthetica9
Copy link
Member Author

Synthetica9 commented Jan 31, 2020 •
edited

:)

Synthetica9 added a commit to Synthetica9/nixpkgs that referenced this pull request Mar 20, 2020
@Synthetica9
treewide: fix redirected urls (again)
9fc5e7e 
Ran the same script as NixOS#78265.
Additionally, manually replaced `http://goodies.xfce.org`
with https.
@Synthetica9 Synthetica9 mentioned this pull request Mar 20, 2020
Merged
@Synthetica9 Synthetica9 mentioned this pull request May 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

@adisbladis adisbladis Awaiting requested review from adisbladis

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: emacs 6.topic: lua 6.topic: nixos 6.topic: python 6.topic: xfce The Xfce Desktop Environment 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Synthetica9 @infinisil