Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

teams: 1.2.00.32451 -> 1.3.00.958 #78263

Merged
merged 1 commit into from Jan 22, 2020
Merged

teams: 1.2.00.32451 -> 1.3.00.958 #78263

merged 1 commit into from Jan 22, 2020

Conversation

liff
Copy link
Contributor

@liff liff commented Jan 22, 2020

Motivation for this change

New release. I have no idea if/where these are announced, but the download link at the distribution site points to this version now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse
Copy link
Member

ping @jonringer for testing as last time there were some issues. I'm willing and able to test if you aren't available... but can't promise results any better than last time as teams has been working well for me 🤷‍♂️

jonringer
jonringer approved these changes Jan 22, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
launches fine
loads conversations well

[3 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/78263
1 package built:
teams

@jonringer jonringer merged commit 2356a43 into NixOS:master Jan 22, 2020
@jonringer
Copy link
Contributor

part of my issues is that I still don't have a DE, just a WM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@liff @aanderse @jonringer