Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wine bump (5.0) #78246

Merged
merged 2 commits into from Jan 28, 2020
Merged

Wine bump (5.0) #78246

merged 2 commits into from Jan 28, 2020

Conversation

lovesegfault
Copy link
Member

Motivation for this change

Well, guess I should've waited with yesterday's bump

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lovesegfault lovesegfault mentioned this pull request Jan 22, 2020
Closed
@lovesegfault
Copy link
Member Author

@avnik @tadeokondrak Can y'all take a look? :)

avnik
avnik approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@avnik avnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@worldofpeace worldofpeace merged commit 16f239a into NixOS:master Jan 28, 2020
anna328p pushed a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
@worldofpeace @anna328p
Merge pull request NixOS#78246 from lovesegfault/wine-bump
8903e36 
Wine bump (5.0)
@lovesegfault lovesegfault deleted the wine-bump branch April 7, 2020 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avnik avnik avnik approved these changes

@tadeokondrak tadeokondrak Awaiting requested review from tadeokondrak

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lovesegfault @avnik @worldofpeace