Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simple-viewer-gl: init at 3.1.7 #82273

Closed
wants to merge 1 commit into from
Closed

simple-viewer-gl: init at 3.1.7 #82273

wants to merge 1 commit into from

Conversation

caadar
Copy link
Contributor

@caadar caadar commented Mar 10, 2020

Motivation for this change

Add simple-viewer-gl - tiny image viewer for Linux and macOS, based on OpenGL. Supported formats: PNG, JPEG, PSD, XCF, SVG, GIF, TIFF, TARGA, ICO, BMP, PNM, DDS, BMP, XWD, SCR (ZX-Spectrum screen), XPM, WebP.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

evenbrenden
evenbrenden reviewed Mar 28, 2020
View reviewed changes
Copy link
Contributor

@evenbrenden evenbrenden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • package name fits guidelines
  • package version fits guidelines
  • package build on x86_64
  • executables tested on x86_64
  • all depending packages build

Tested on NixOS. Tried it on Ubuntu 18.04 too, but it segfaults. That's probably not on you, though.

SuperSandro2000
SuperSandro2000 requested changes Nov 29, 2020
View reviewed changes
pkgs/applications/graphics/simple-viewer-gl/default.nix
Comment on lines +61 to +65
pushd .. >/dev/null
install -D -m0644 -t $out/share/doc/ config.example README.md Copying.txt
install -D -m0644 -t $out/share/applications/ sviewgl.desktop
install -D -m0644 -t $out/share/icons/ res/Icon-1024.png
popd >/dev/null
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pushd .. >/dev/null
install -D -m0644 -t $out/share/doc/ config.example README.md Copying.txt
install -D -m0644 -t $out/share/applications/ sviewgl.desktop
install -D -m0644 -t $out/share/icons/ res/Icon-1024.png
popd >/dev/null
pushd
install -D -m0644 -t $out/share/doc/ config.example README.md Copying.txt
install -D -m0644 -t $out/share/applications/ sviewgl.desktop
install -D -m0644 -t $out/share/icons/ res/Icon-1024.png
pop

pkgs/applications/graphics/simple-viewer-gl/default.nix
Comment on lines +75 to +77
};

}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
};
}
};
}

@SuperSandro2000
Copy link
Member 

trying https://bitbucket.org/andreyu/simple-viewer-gl/get/v3.1.7.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  977k  100  977k    0     0   816k      0  0:00:01  0:00:01 --:--:--  816k
unpacking source archive /build/v3.1.7.tar.gz
builder for '/nix/store/0r8h125j1pmds599b1b1pn0qvynq94vn-source.drv' failed to produce output path '/nix/store/1qj8d9j6pb10cijmmm047286pcjl7y90-source'
cannot build derivation '/nix/store/da6lyd0qlglz5aphrd6y8z5krdhmd7np-simple-viewer-gl-3.1.7.drv': 1 dependencies couldn't be built
error: build of '/nix/store/da6lyd0qlglz5aphrd6y8z5krdhmd7np-simple-viewer-gl-3.1.7.drv' failed

@caadar caadar closed this Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@evenbrenden evenbrenden evenbrenden approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@caadar @SuperSandro2000 @evenbrenden