Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ngscopeclient/scopehal
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: abb9978e1de5
Choose a base ref
...
head repository: ngscopeclient/scopehal
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2cd392c580e6
Choose a head ref
  • 2 commits
  • 24 files changed
  • 1 contributor

Commits on Mar 11, 2020

  1. Copy the full SHA
    232aa77 View commit details
  2. Copy the full SHA
    2cd392c View commit details
5 changes: 5 additions & 0 deletions scopehal/AgilentOscilloscope.cpp
Original file line number Diff line number Diff line change
@@ -148,6 +148,11 @@ AgilentOscilloscope::~AgilentOscilloscope()
////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
// Accessors

string AgilentOscilloscope::GetDriverName()
{
return "agilent";
}

unsigned int AgilentOscilloscope::GetInstrumentTypes()
{
return Instrument::INST_OSCILLOSCOPE;
2 changes: 2 additions & 0 deletions scopehal/AgilentOscilloscope.h
Original file line number Diff line number Diff line change
@@ -37,6 +37,8 @@ class AgilentOscilloscope : public SCPIOscilloscope
virtual ~AgilentOscilloscope();

public:
virtual std::string GetDriverName();

//Device information
virtual unsigned int GetInstrumentTypes();

10 changes: 10 additions & 0 deletions scopehal/AntikernelLogicAnalyzer.cpp
Original file line number Diff line number Diff line change
@@ -93,6 +93,16 @@ AntikernelLogicAnalyzer::~AntikernelLogicAnalyzer()
////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
// Information queries

string AntikernelLogicAnalyzer::GetTransportConnectionString()
{
return m_transport->GetConnectionString();
}

string AntikernelLogicAnalyzer::GetDriverName()
{
return "akila";
}

void AntikernelLogicAnalyzer::SendCommand(uint8_t opcode)
{
m_transport->SendRawData(1, &opcode);
3 changes: 3 additions & 0 deletions scopehal/AntikernelLogicAnalyzer.h
Original file line number Diff line number Diff line change
@@ -44,6 +44,9 @@ class AntikernelLogicAnalyzer
AntikernelLogicAnalyzer(SCPITransport* transport);
virtual ~AntikernelLogicAnalyzer();

virtual std::string GetTransportConnectionString();
virtual std::string GetDriverName();

virtual std::string GetName();
virtual std::string GetVendor();
virtual std::string GetSerial();
1 change: 0 additions & 1 deletion scopehal/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -27,7 +27,6 @@ set(SCOPEHAL_SOURCES
AntikernelLogicAnalyzer.cpp
LeCroyOscilloscope.cpp
SiglentSCPIOscilloscope.cpp
RedTinLogicAnalyzer.cpp
RigolOscilloscope.cpp
RohdeSchwarzOscilloscope.cpp
RohdeSchwarzHMC8012Multimeter.cpp
5 changes: 5 additions & 0 deletions scopehal/LeCroyOscilloscope.cpp
Original file line number Diff line number Diff line change
@@ -320,6 +320,11 @@ LeCroyOscilloscope::~LeCroyOscilloscope()
////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
// Device information

string LeCroyOscilloscope::GetDriverName()
{
return "lecroy";
}

OscilloscopeChannel* LeCroyOscilloscope::GetExternalTrigger()
{
return m_extTrigChannel;
1 change: 1 addition & 0 deletions scopehal/LeCroyOscilloscope.h
Original file line number Diff line number Diff line change
@@ -55,6 +55,7 @@ class LeCroyOscilloscope
void DetectOptions();

public:
virtual std::string GetDriverName();

//Device information
virtual std::string GetName();
4 changes: 3 additions & 1 deletion scopehal/Oscilloscope.cpp
Original file line number Diff line number Diff line change
@@ -172,7 +172,9 @@ string Oscilloscope::SerializeConfiguration(map<void*, int>& idmap, int& nextID)
config += tmp;
snprintf(tmp, sizeof(tmp), " serial: \"%s\"\n", GetSerial().c_str());
config += tmp;
snprintf(tmp, sizeof(tmp), " path: \"%s\"\n", "connection_string_not_yet_implemented");
snprintf(tmp, sizeof(tmp), " transport: \"%s\"\n", GetTransportConnectionString().c_str());
config += tmp;
snprintf(tmp, sizeof(tmp), " driver: \"%s\"\n", GetDriverName().c_str());
config += tmp;

//Save channels
10 changes: 10 additions & 0 deletions scopehal/Oscilloscope.h
Original file line number Diff line number Diff line change
@@ -347,6 +347,16 @@ class Oscilloscope : public virtual Instrument
*/
virtual bool IsTriggerArmed() =0;

/**
@brief Gets the connection string for our transport
*/
virtual std::string GetTransportConnectionString() =0;

/**
@brief Gets the registered name of this driver
*/
virtual std::string GetDriverName() =0;

public:
////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
// Memory depth / sample rate control.
Loading