Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openrgb: init at unstable-2020-03-03 #82269

Closed
wants to merge 2 commits into from
Closed

openrgb: init at unstable-2020-03-03 #82269

wants to merge 2 commits into from

Conversation

evanjs
Copy link
Member

@evanjs evanjs commented Mar 10, 2020

Motivation for this change

https://gitlab.com/CalcProgrammer1/OpenRGB/-/wikis/home

Currently, there are no GUI-based tools to manage e.g. Razer devices on NixOS.
This utility provides a way to manage RGB functionality for many different types of devices.

Notes

This application will currently segfault if you try to detect or dump devices without access to i2c devices (or rather, it won't perform any length checks, and will try to get the current index of an empty list of SMBus devices)
Alternatively, you can just run the application as root.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @adisbladis

evanjs
evanjs commented Mar 10, 2020
View reviewed changes
pkgs/applications/misc/openrgb/default.nix

date = "2020-03-03";

src = fetchFromGitHub {
Copy link
Member Author

@evanjs evanjs Mar 10, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used GitHub because we need submodules, and the source seems to be equivalent with what's available on GitLab

evanjs
evanjs commented Mar 10, 2020
View reviewed changes
pkgs/applications/misc/openrgb/default.nix

buildInputs = [ libusb1 hidapi wrapQtAppsHook ];

propagatedBuildInputs = [ hicolor-icon-theme openrazer-daemon ];
Copy link
Member Author

@evanjs evanjs Mar 10, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably don't actually need hicolor-icon theme; this was probably added when I was trying to figure out why the application was segfaulting

@evanjs
Copy link
Member Author

evanjs commented Mar 10, 2020

I’m also currently unable to access/list Razer devices from this application, even when running as root.

Didn’t see any explicit deps in the project for openrazer on Linux, so I’m not sure why this is the case or where to look.

@evanjs evanjs mentioned this pull request Mar 14, 2020
Closed
10 tasks
@evanjs
Copy link
Member Author

evanjs commented Mar 29, 2020

I still get some pretty nasty crashes when attempting to detect devices and etc, but at the very least, my Razer devices now appear and I am able to set various effects.

@evanjs
Copy link
Member Author

evanjs commented Mar 29, 2020 •
edited

Opened an issue related to the crashes I'm experiencing on the main repository.

Update: Fixed via https://gitlab.com/CalcProgrammer1/OpenRGB/-/commit/eba9fc0213b1ffe77b5bff4daf9f5bdeef3a6d16

@JJJollyjim
Copy link
Member

Is there a reason for this to remain a draft? Version 0.2 is out now, btw.

@JJJollyjim
Copy link
Member

Superseded by #90691, which has been merged.

@evanjs evanjs closed this Jun 20, 2020
@evanjs
Copy link
Member Author

evanjs commented Jun 20, 2020

Closed by #90691

@jonringer
Copy link
Contributor

ah, sorry I didn't see this.

I also used the process to make this "how to add a package to nixpkgs video" https://www.youtube.com/watch?v=fvj8H5yUKu8

@evanjs
Copy link
Member Author

evanjs commented Jun 20, 2020 •
edited

ah, sorry I didn't see this.

I also used the process to make this "how to add a package to nixpkgs video" https://www.youtube.com/watch?v=fvj8H5yUKu8

All good! Thanks for getting it merged! One more TODO off my list! 😀

Also: did not realize you made that video, thanks!
This should be helpful for getting the new guys into NixOS/nixpkgs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@evanjs @JJJollyjim @jonringer