Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cups-pdf: init at 3.0.1 #82270

Closed
wants to merge 1 commit into from
Closed

cups-pdf: init at 3.0.1 #82270

wants to merge 1 commit into from

Conversation

caadar
Copy link
Contributor

@caadar caadar commented Mar 10, 2020

Motivation for this change

Add cups-pdf, designed to produce PDF files in a heterogeneous network by providing a PDF printer on the central fileserver.

Notes from patched fork:

How is this better than a Save-as-PDF or Print-as-file functionality in many GTK/QT interfaces?

  1. You can do post-processing, for example choose pdf filename and saving location in a standard file save dialog, and automatically open generated PDF.
  2. Use PDF printing from non GTK/QT apps, like Wine
  3. Provide consistent PDF printing experience
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

pkgs/misc/cups-pdf/default.nix Outdated Show resolved Hide resolved
pkgs/misc/cups-pdf/default.nix Outdated Show resolved Hide resolved
nixos/modules/services/printing/cups-pdf.nix Show resolved Hide resolved
@ryantm
Copy link
Member

ryantm commented Sep 29, 2020

Result of nixpkgs-review pr 82270 1

1 package built:
- cups-pdf

@stale
Copy link

stale bot commented Mar 31, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 31, 2021
@onny
Copy link
Contributor

onny commented Sep 7, 2022

This is a really cool addition. Might need an update

$ git merge --no-commit --no-ff c1d52ea4c4818e994b646e1a2c5cbb26301d72e4
Auto-merging pkgs/top-level/all-packages.nix
Automatic merge went well; stopped before committing as requested
error: attribute 'lib' missing

       at /home/onny/.cache/nixpkgs-review/pr-82270/nixpkgs/pkgs/misc/cups/drivers/cups-pdf/default.nix:56:15:

           55|
           56|   meta = with stdenv.lib; {
             |               ^
           57|     description = "A virtual PDF printer for CUPS";
       Did you mean glibc?
(use '--show-trace' to show detailed location information)
nix --experimental-features nix-command --system x86_64-linux eval --json --impure --expr (import /nix/store/migyqw96w36hb22cyh5sjv07l6khnd4f-nixpkgs-review-2.7.0/lib/python3.10/site-packages/nixpkgs_review/nix/evalAttrs.nix { allowAliases = false; attr-json = /tmp/tmp64_pxdae; }) failed to run, /tmp/tmp64_pxdae was stored inspection
https://github.com/NixOS/nixpkgs/pull/82270 failed to build
$ git worktree prune

@onny onny marked this pull request as draft September 7, 2022 08:02
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 7, 2022
@AndersonTorres
Copy link
Member

Closing as dead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants