Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slimserver: 7.9.1 -> 7.9.2 #82296

Merged
merged 1 commit into from Nov 24, 2020
Merged

slimserver: 7.9.1 -> 7.9.2 #82296

merged 1 commit into from Nov 24, 2020

Conversation

nyanloutre
Copy link
Member

Motivation for this change

Building and running.

But I have a strange problem when using it on 20.03 (that was also happening with 7.9.1), the scan will first detect all files (the number displayed is correct) but then a lot of them are missing in the album view. I can only play all my library from the directory view.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nyanloutre
Copy link
Member Author

cc @phile314

phile314
phile314 approved these changes Mar 12, 2020
View reviewed changes
Copy link
Contributor

@phile314 phile314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not yet tested either 7.9.1 or 7.9.2 on NixOS 20.03, so I don't know what's up with the bug you have seen. The changes look good to me.

@nyanloutre
Copy link
Member Author

@phile314 do you know what debug options could help me find why many songs are ignored during scan ?

@phile314
Copy link
Contributor

The following options might help:

    --logfile        => Specify a file for error logging.  Specify 'syslog' to log to syslog.
    --logging        => Enable logging for the specified comma separated categories

@nyanloutre
Copy link
Member Author

I opened an issue upstream LMS-Community/slimserver#333

@stale
Copy link

stale bot commented Nov 3, 2020

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 3, 2020
@nyanloutre
Copy link
Member Author

I still have the bug with missing tracks after a scan

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 9, 2020
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 82296 run on x86_64-linux 1

1 package built:
  • slimserver

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 82296 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • slimserver

@SuperSandro2000 SuperSandro2000 merged commit 38fce64 into NixOS:master Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phile314 phile314 phile314 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nyanloutre @phile314 @SuperSandro2000