@jonringer per https://discourse.nixos.org/t/adopting-a-new-pkg/6178/2

It was suggested that I add myself as a maintainer. I assumed this meant my github username. Apparently this didn't get by tests. Did it mean that I needed to add my name to stdenv.lib.maintainers as well?

Open to all suggestions.

Thanks!

@jonringer per https://discourse.nixos.org/t/adopting-a-new-pkg/6178/2

It was suggested that I add myself as a maintainer. I assumed this meant my github username. Apparently this didn't get by tests. Did it mean that I needed to add my name to stdenv.lib.maintainers as well?

yes, you need to add yourself to the maintainers list, please take a look at #81835 for how to do that commit

Thanks Jon. Super instructive! I'll work through these.

Thanks again, @jonringer. Very welcoming experience!

also, your commit message should be:

ams: init at 2.1.2

Right. Will conform next time!

Is this essentially mergeable now @jonringer?

git history needs to be cleaned up:

git reset HEAD~6
git add maintainers
git commit -m "maintainers: add sjfloat"
git add pkgs/
git commit -m "ams: init at 2.1.2"
git push .. .. --force

this will make it two commits, one to add you as a maintainer in nixpkgs, the other to add your package.

IOW, you'd like this squashed and the commit message corrected. Certainly.

Unrelated to PR: the patch should probably be upstreamed so that others can benefit from it

Actually, I think the patch probably already is upstream. I originally based my derivation on a Debian package, and I found the patch there. When I got things working and I switched to pulling directly from the upstream source, I had a lot of troubles trying to build a later commit. I hope to move quickly to resolving those, but they weren't critical and did not substantially affect the user experience; it was very usable as I built it and I wanted to make it available first.

Thanks again!

IOW, you'd like this squashed and the commit message corrected. Certainly.

Yea, to help maintainership, commit messages are important to quickly gather what changes were done. You can read the guidance https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes and also https://nixos.org/nixpkgs/manual/#chap-submitting-changes

It is if the jack service isn't running. You'll get similar errors from other jack clients in such a case.

We might be able to do better about providing reasonable defaults for those environment variables though.

Looking at the commit that switches to Qt 5 by default, something like configureFlags = [ "--enable-qt5" ] should work in 2.1.2 too. There is no excuse to use Qt 4 today. #33248

Yeah, Qt5 is going to take some puzzling out. I managed to build something, but I got runtime errors due, I assume, to needing wrapQtAppsHook. It's not clear to me yet how to go about that.

Just add wrapQtAppsHook to nativeBuildInputs.

You need to use qt5.wrapQtAppsHook, or libsForQt5.callPackage.

You need to use qt5.wrapQtAppsHook, or libsForQt5.callPackage.

Thanks!

Everything builds and functions properly. I'm going to look it over and push again.

Jon’s suggestions in the Files tab still apply.

Jon’s suggestions still apply.

As far as I know, I addressed them all. Is there anything in particular that I may have missed?

I hope this nails it. Sorry for all the bother!

By the way, do you have your committer name/email set to = intentionally?

By the way, do you have your commiter name/email set to = intentionally?

Hmm. Thanks for bringing that to my attention.

@GrahamcOfBorg build ams

By the way, do you have your committer name/email set to = intentionally?

I'm not sure I understand why that is. It's not the case in my local git config, nor is it so in my github account.

You can use git config --show-origin user.name to see where does the value come from.