-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Octoprint 1.4.0 with Python 3 (WIP; help needed) #82294
Conversation
0db6a8e
to
c6014c1
Compare
checkPhase = '' | ||
HOME=$(mktemp -d) nosetests ${lib.optionalString stdenv.isDarwin "--exclude=test_set_external_modification"} | ||
HOME=$(mktemp -d) nosetests --exclude-test=util.test_pip.test_check_setup ${lib.optionalString stdenv.isDarwin "--exclude=test_set_external_modification"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--exclude-test
does not exist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it does: https://pypi.org/project/nose-exclude/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But if that's not part of your checkInputs, how is it pulled in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also --ignore-files=test_pip.py
is probably required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And the sentry-sdk tests fail for me, so i disabled them locally. This makes the package build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure, but IIRC the exclude flag was properly doing the job at one point while I was tinkering.
Do you mean you got Octoprint to build entirely?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I did.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just by adding doCheck = false;
to sentry-sdk? Because that doesn't help for me:
Found duplicated packages in closure for dependency 'MarkupSafe':
MarkupSafe 1.1.1 (/nix/store/qvpsgs0sl3sh3knm5b1ya49x5zlf9v6j-python3-3.7.6/lib/python3.7/site-packages)
MarkupSafe 1.1.1 (/nix/store/ig1lgbvd518i5yci62mm8hxpsjm9hlvy-python3.7-MarkupSafe-1.1.1/lib/python3.7/site-packages)
And now this is happening too:
Found duplicated packages in closure for dependency 'urllib3':
urllib3 1.25.8 (/nix/store/qvpsgs0sl3sh3knm5b1ya49x5zlf9v6j-python3-3.7.6/lib/python3.7/site-packages)
urllib3 1.25.8 (/nix/store/ka86vbis93vyyj3rn494n5yc3ymk9x24-python3.7-urllib3-1.25.8/lib/python3.7/site-packages)
Found duplicated packages in closure for dependency 'six':
six 1.14.0 (/nix/store/qvpsgs0sl3sh3knm5b1ya49x5zlf9v6j-python3-3.7.6/lib/python3.7/site-packages)
six 1.14.0 (/nix/store/f2p4y8awg8px77wj2p8x5v8cv4sr7rgw-python3.7-six-1.14.0/lib/python3.7/site-packages)
Found duplicated packages in closure for dependency 'pyparsing':
pyparsing 2.4.6 (/nix/store/qvpsgs0sl3sh3knm5b1ya49x5zlf9v6j-python3-3.7.6/lib/python3.7/site-packages)
pyparsing 2.4.6 (/nix/store/kdbxn8yk7v8j36slygdhz59xy1j7s6ii-python3.7-pyparsing-2.4.6/lib/python3.7/site-packages)
Found duplicated packages in closure for dependency 'pyasn1':
pyasn1 0.4.8 (/nix/store/qvpsgs0sl3sh3knm5b1ya49x5zlf9v6j-python3-3.7.6/lib/python3.7/site-packages)
pyasn1 0.4.8 (/nix/store/d14dfx619lgcaqcxr16i54j43s259yan-python3.7-pyasn1-0.4.8/lib/python3.7/site-packages)
Found duplicated packages in closure for dependency 'packaging':
packaging 20.3 (/nix/store/qvpsgs0sl3sh3knm5b1ya49x5zlf9v6j-python3-3.7.6/lib/python3.7/site-packages)
packaging 20.1 (/nix/store/wrhaln323yi4i9d4s51ky92sj1r2cyky-python3.7-packaging-20.1/lib/python3.7/site-packages)
Found duplicated packages in closure for dependency 'idna':
idna 2.9 (/nix/store/qvpsgs0sl3sh3knm5b1ya49x5zlf9v6j-python3-3.7.6/lib/python3.7/site-packages)
idna 2.8 (/nix/store/g38lfy4g4k5g0aaipzrmql9nzrbl3cn7-python3.7-idna-2.8/lib/python3.7/site-packages)
Found duplicated packages in closure for dependency 'certifi':
certifi 2019.11.28 (/nix/store/qvpsgs0sl3sh3knm5b1ya49x5zlf9v6j-python3-3.7.6/lib/python3.7/site-packages)
certifi 2019.11.28 (/nix/store/gr6i7d5zbw6x62k7i0vzkfcdff3rqrbb-python3.7-certifi-2019.11.28/lib/python3.7/site-packages)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff and build.log https://gist.github.com/mweinelt/5b12577a07e952157000247c536f37eb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm getting the same result as @mweinelt. @WhittlesJr Do you have sandboxing disabled by any chance?
This is the commit I am currently testing: 3326c99398c0e27f4abcb9431773b8e6a48e6b68, and here is the diff between yours and mine: https://github.com/WhittlesJr/nixpkgs/compare/WhittlesJr:octoprint-overrides..lopsided98:octoprint-update |
Version that builds #82392 |
Motivation for this change
See #82292
This is a stab at updating to Octoprint 1.4.0 with Python 3. It's not currently working, because of a mysterious duplicated package that I can't seem to figure out. Jinja2 is not building because it sees a duplicated dependency (MarkupSafe).
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)@abbradar @gebner @peterhoeg