Skip to content

nixos/release-notes: mention that dhcpcd stopped giving IPv4 addresses to bridges #82295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2020
Merged

nixos/release-notes: mention that dhcpcd stopped giving IPv4 addresses to bridges #82295

merged 1 commit into from
Apr 8, 2020
+11 −0

Conversation

erictapen
Copy link
Member

Motivation for this change

This is about an change from upstream dhcpcd. It is backwards incompatible as this locked me out of my box.

Ignore some virtual interfaces such as Tap and Bridge by default

This was my setup, when I upgraded from nixos-19.09 to nixos-20.03:

{ config, pkgs, ... }:{
  networking = {
    bridges.br0 = {
      interfaces = [ "enp2s0" "enp3s0" "enp4s0" ];
    };
    interfaces = {
      br0.useDHCP = true;
      enp2s0.useDHCP = false;
      enp3s0.useDHCP = false;
      enp4s0.useDHCP = false;
    };
  };
}

When I rebooted the system, I noticed that br0 doesn't get an IPv4 address anymore. The reason was, that dhcpcd didn't consider a bridge as an interface, that would get an address by default.

My solution was then to change my config to this:

{ config, pkgs, ... }:{
  networking = {
    bridges.br0 = {
      interfaces = [ "enp2s0" "enp3s0" "enp4s0" ];
    };
    dhcpcd.allowInterfaces = [
      "br0"
      # and all other interfaces where I had set useDHCP = true!
    ];
  };
}

As I explain in the commit message, I don't see an easy way to fix this edge case. The only thing that comes to my mind right now is that we could give out an error if someone wants to set useDHCP on a bridge?

Things done

Inform users of nixos-20.03, that their setup might break.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Pinging @edolstra @fpletz as they are the maintainer of dhcpcd.

Sorry, something went wrong.

@erictapen erictapen changed the title nixos/release-notes: mention that dhcpcd stopped giving IPv4 addresse to bridges nixos/release-notes: mention that dhcpcd stopped giving IPv4 addresses to bridges Mar 11, 2020
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 11, 2020
@erictapen
Copy link
Member Author

Also pinging @worldofpeace @disassembler as this might be important for the release? Sorry in advance if I overestimate this issue.

@erictapen erictapen force-pushed the dhcpcd-release-notes branch 2 times, most recently from fab0ace to 1977476 Compare March 31, 2020 19:45
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/go-no-go-meeting-nixos-20-03-markhor/6495/11

@lheckemann
Copy link
Member

Interfaces with useDHCP set should probably be added to allowInterfaces automatically… Do you see any issues with that? I fully agree that this should be sorted one way or another before the 20.03 release.

@lheckemann lheckemann added this to the 20.03 milestone Apr 1, 2020
@lheckemann lheckemann added the 1.severity: blocker This is preventing another PR or issue from being completed label Apr 1, 2020
@rnhmjoj
Copy link
Contributor

rnhmjoj commented Apr 1, 2020

It seems pretty serious. I would put that note on top of the list.

@erictapen
Copy link
Member Author

Interfaces with useDHCP set should probably be added to allowInterfaces automatically…

The problem is, once you use allowInterfaces, there is no implicit discovery of interfaces anymore. Everything has to be explicitly listed in allowInterfaces. See NixOS option and man 5 dhcpcd.conf for this:

     allowinterfaces pattern
             When discovering interfaces, the interface name must match pattern which is a space or comma
             separated list of patterns passed to fnmatch(3).  If the same interface is matched in
             denyinterfaces then it is still denied.

networking.interfaces.<name?>.useDHCP defaults to true, so a lot of people might have no config at all to use DHCP on their interfaces. I'm afraid this would break peoples setups more than it'd save them.

I think we should stick with informing people about the breakage in the release notes. Optionally we could throw an error if people had networking.interfaces.<name?>.useDHCP set on a bridge, as this makes never sense with the new dhcpcd version.

@erictapen erictapen force-pushed the dhcpcd-release-notes branch from 1977476 to 719af38 Compare April 3, 2020 19:29
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/go-no-go-meeting-nixos-20-03-markhor/6495/16

@kyren
Copy link
Contributor

kyren commented Apr 3, 2020 •
edited
Loading

I have this same setup, and as of my current nixpkgs version of b0c2858 it seems to work if you set networking.useDHCP = false; as the manpage of configuration.nix suggests.

Currently my configuration is something like this:

networking = {
  useDHCP = false;
  networkmanager.enable = false;

  bridges.br0.interfaces = [ "enp4s0" "enp6s0" ];
  interfaces.br0.useDHCP = true;
};

And this seems to work fine? Is this expected, or is there potentially something else different about my configuration that's making this work?

I'm not sure why this works, but if it does it seems easier to suggest changing the networking.useDHCP setting rather than networking.dhcpcd.allowInterfaces.

Edit: Just to be clear, I also experienced this bug after switching to 20.03 and I was also locked out of several machines, but after setting networking.useDHCP = false; and interfaces.br0.useDHCP = true; I started getting IPv4 addresses again.

@erictapen
Copy link
Member Author

I have this same setup, and as of my current nixpkgs version of b0c2858 it seems to work if you set networking.useDHCP = false; as the manpage of configuration.nix suggests.

@kyren Thanks for the hint! The logic that configures an explicit list of interfaces if notworking.useDHCP = false is defined in modules/services/networking/dhcpcd.nix.

...it does it seems easier to suggest changing the networking.useDHCP setting rather than networking.dhcpcd.allowInterfaces.

I agree and will change the PR accordingly.

@erictapen
nixos/release-notes: mention that dhcpcd stopped giving IPv4 addresse…
eeeb2bf 
…s to bridges by default

This is an backward incompatible change from upstream dhcpcd [0], as
this could have easily locked me out of my box.

As dhcpcd doesn't allow to use only a blacklist (denyinterfaces in
dhcpcd.conf) of devices and use all remaining devices, while explicitly
allowing some interfaces like bridges, I think the best option would be
to not change anything about it and just educate the users here about
that edge case and how to solve it.

[0] https://roy.marples.name/archives/dhcpcd-discuss/0002621.html
@erictapen erictapen force-pushed the dhcpcd-release-notes branch from 719af38 to eeeb2bf Compare April 3, 2020 23:45
@erictapen erictapen mentioned this pull request Apr 4, 2020
Merged
10 tasks
@erictapen
Copy link
Member Author

I proposed an assertion in #84221. As this issue is already a blocker, I think #84221 should be also either marked as a blocker or else rejected, as the error message will be primarily useful to people doing the migration to 20.03.

@worldofpeace worldofpeace self-assigned this Apr 8, 2020
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/go-no-go-meeting-nixos-20-03-markhor/6495/19

worldofpeace
worldofpeace approved these changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and renders fine for me.

@worldofpeace worldofpeace merged commit 84aa023 into NixOS:release-20.03 Apr 8, 2020
@worldofpeace
Copy link
Contributor

forward ported 788f572

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace

Assignees

@worldofpeace worldofpeace

Labels
1.severity: blocker This is preventing another PR or issue from being completed 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@erictapen @nixos-discourse @lheckemann @rnhmjoj @kyren @worldofpeace