Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

electron-cash: fix build #82235

Merged
merged 1 commit into from Mar 10, 2020
Merged

electron-cash: fix build #82235

merged 1 commit into from Mar 10, 2020

Conversation

jluttine
Copy link
Member

Motivation for this change

This commit fixes #82221. Requirements file had changed a bit so the patching needed updating.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jluttine jluttine mentioned this pull request Mar 10, 2020
Closed
@ofborg ofborg bot requested review from Lassulus and nyanloutre March 10, 2020 11:38
@jluttine
Copy link
Member Author

cc: @nyanloutre @Lassulus

@Lassulus Lassulus merged commit 57930a5 into NixOS:master Mar 10, 2020
@Lassulus
Copy link
Member

seems to work as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus Awaiting requested review from Lassulus

@nyanloutre nyanloutre Awaiting requested review from nyanloutre

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

electron-cash broken
2 participants
@jluttine @Lassulus