Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefox-bin: 73.0.1 -> 74.0 #82257

Closed
wants to merge 1 commit into from
Closed

firefox-bin: 73.0.1 -> 74.0 #82257

wants to merge 1 commit into from

Conversation

tokudan
Copy link
Contributor

@tokudan tokudan commented Mar 10, 2020 •
edited

Motivation for this change

Update done using nixpkgs attributes:
firefox-bin-unwrapped.updateScript
firefox-beta-bin-unwrapped.updateScript
firefox-devedition-bin-unwrapped.updateScript

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tokudan
Copy link
Contributor Author

tokudan commented Mar 10, 2020

@GrahamcOfBorg build firefox firefox-bin
@GrahamcOfBorg test firefox

@tokudan tokudan changed the title Master ff74 firefox{,bin}: 73.0.1 -> 74.0 Mar 10, 2020
@tokudan tokudan changed the title firefox{,bin}: 73.0.1 -> 74.0 firefox-bin: 73.0.1 -> 74.0 Mar 10, 2020
@vcunat
Copy link
Member

vcunat commented Mar 10, 2020

The compiled one needs:

(maybe something else as well?)

@tokudan
Copy link
Contributor Author

tokudan commented Mar 10, 2020

@andir will take care of firefox, this PR will be firefox-bin only

@tokudan
Copy link
Contributor Author

tokudan commented Mar 10, 2020

@GrahamcOfBorg build firefox-bin firefox-devedition-bin firefox-beta-bin

@vcunat
Copy link
Member

vcunat commented Mar 10, 2020

Yes, it's probably better to split them in this case.

@ofborg ofborg bot requested review from edolstra and andir March 10, 2020 16:16
@tokudan
Copy link
Contributor Author

tokudan commented Mar 10, 2020

works-for-me©
All three versions of firefox-bin can be executed and are usable on my system.

@andir
Copy link
Member

andir commented Mar 10, 2020

Small nitpick: Usually we update each of them in a separated commit. Can you fix that? They all work for me locally (as well).

@andir andir mentioned this pull request Mar 10, 2020
Merged
10 tasks
vcunat
vcunat approved these changes Mar 11, 2020
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine for me.

vcunat pushed a commit that referenced this pull request Mar 12, 2020
@tokudan @vcunat
firefox-bin: 73.0 -> 74.0 (from PR #82257)
8899c72
@vcunat
Copy link
Member

vcunat commented Mar 12, 2020

I picked the default variant as 8899c72. This was conflicting due to 1cbef11 and af48019 updating the non-default variants to b2 (this PR has b1).

@vcunat vcunat closed this Mar 12, 2020
vcunat pushed a commit that referenced this pull request Mar 12, 2020
@tokudan @vcunat
firefox-bin: 73.0 -> 74.0 (from PR #82257)
fa88f6a 
(cherry picked from commit 8899c72)
Brief testing showed no issues.
@tokudan tokudan deleted the master-ff74 branch March 14, 2020 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@edolstra edolstra Awaiting requested review from edolstra

@andir andir Awaiting requested review from andir

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tokudan @vcunat @andir