Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gummi: 0.6.6 -> 0.8.1 #82331

Merged
merged 1 commit into from Mar 12, 2020
Merged

gummi: 0.6.6 -> 0.8.1 #82331

merged 1 commit into from Mar 12, 2020

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Mar 11, 2020

Motivation for this change

New upstream release. Ported from gtk2 to gtk3!

Spellchecking is still broken, though. That is not a problem specific to gummi, but gtkspell/enchant, as far as I can tell.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @flokli

@ofborg ofborg bot requested a review from flokli March 11, 2020 16:45
@ofborg ofborg bot requested a review from flokli March 12, 2020 03:15
@flokli flokli merged commit 8f45fe6 into NixOS:master Mar 12, 2020
@ajs124 ajs124 deleted the upd/gummi branch March 13, 2020 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli Awaiting requested review from flokli

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ajs124 @flokli