Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nss: 3.49.2 -> 3.51 #82247

Merged
merged 1 commit into from Mar 10, 2020
Merged

nss: 3.49.2 -> 3.51 #82247

merged 1 commit into from Mar 10, 2020

Conversation

KamilaBorowska
Copy link
Member

Motivation for this change

Bump to latest NSS version for upcoming Firefox bump.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge it fast, so that we don't block Firefox update for long.

@vcunat vcunat merged commit 60c646c into NixOS:staging Mar 10, 2020
@andir
Copy link
Member

andir commented Mar 10, 2020

@vcunat It seems like there is no current "staging-next" branch going. You and @FRidh usually did that. Do you mind merging staging into staging-next and opening the usual PR?

@vcunat
Copy link
Member

vcunat commented Mar 10, 2020

I did that in the meantime. Hydra's been running a new evaluation including nss for 20 mins now.

@vcunat
Copy link
Member

vcunat commented Mar 10, 2020

BTW, when I see in the build log that it names the intermediate object files according to your currently running kernel version... I just hope they're reasonable and this won't cause trouble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants