Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wire-desktop (linux): 3.12.2916 -> 3.14.2921 #82236

Closed
wants to merge 1 commit into from
Closed

wire-desktop (linux): 3.12.2916 -> 3.14.2921 #82236

wants to merge 1 commit into from

Conversation

turboMaCk
Copy link
Member

Linux client asks for update. CHANGELOG. It seems there is no Darwin version yet - updating only linux.

  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@turboMaCk
Copy link
Member Author

@GrahamcOfBorg build wire-desktop

@turboMaCk
Copy link
Member Author

@arianvp 👋 can you review this? Thanks.

@arianvp
Copy link
Member

arianvp commented Mar 10, 2020

AFAIK 3.14 should be out for mac too. let me see what's up with that

@toonn
Copy link
Contributor

toonn commented Mar 10, 2020

The linux release isn't even up on the github repo. Let's also see what's up with that?

@arianvp
Copy link
Member

arianvp commented Mar 10, 2020

I have asked for clarification internally. Lets wait with this until the release notes are also up on github

@toonn toonn mentioned this pull request Mar 15, 2020
Merged
10 tasks
@turboMaCk turboMaCk closed this Mar 16, 2020
@toonn
Copy link
Contributor

toonn commented Mar 16, 2020

Btw, @turboMaCk, it could be your client asked for an update of the "Wire for Web" part of wire-desktop. That happens often and automatically afaict, if you quit and restart it's updated or if you click "update now."

P.s.: This is actually quite a severe wart I only found out about recently. In principle it allows them to update the encryption code you're running remotely. Which means they could turn it off completely whenever they want/are compelled through warrants or whatever. Seems like bad design for supposedly secure communication.

@turboMaCk turboMaCk deleted the wire-desktop-3.14 branch February 2, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

@arianvp arianvp Awaiting requested review from arianvp

@Kiwi Kiwi Awaiting requested review from Kiwi

@toonn toonn Awaiting requested review from toonn

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@turboMaCk @arianvp @toonn