Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport-19.09] yubioath-desktop: 4.3.6 -> 5.0.2 #82254

Closed
wants to merge 2 commits into from
Closed

[backport-19.09] yubioath-desktop: 4.3.6 -> 5.0.2 #82254

wants to merge 2 commits into from

Conversation

rissson
Copy link
Member

@rissson rissson commented Mar 10, 2020

Motivation for this change

Backporting #81162

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @Mic92

@rissson
maintainers: add risson
cf19197 
(cherry picked from commit d1b61a9)
@rissson
yubioath-desktop: 4.3.6 -> 5.0.2
e2031e4 
(cherry picked from commit 3d0626f)
@ofborg ofborg bot requested a review from Mic92 March 10, 2020 15:43
@Mic92 Mic92 changed the title yubioath-desktop: 4.3.6 -> 5.0.2 [backport] yubioath-desktop: 4.3.6 -> 5.0.2 Mar 10, 2020
@Mic92
Copy link
Member

Mic92 commented Mar 10, 2020

What was the reason for this backport?

@Mic92 Mic92 changed the title [backport] yubioath-desktop: 4.3.6 -> 5.0.2 [backport-19.09] yubioath-desktop: 4.3.6 -> 5.0.2 Mar 10, 2020
@rissson
Copy link
Member Author

rissson commented Mar 11, 2020

What was the reason for this backport?

Being able to use the new version while being on the 19.09 channel.

@Mic92
Copy link
Member

Mic92 commented Mar 11, 2020

We usually only backport bugfixes and security fixes. There are ways of using unstable channels in a stable channel as well or you could add it to an overlay.

@rissson
Copy link
Member Author

rissson commented Mar 11, 2020

According to the release notes [1], there have been no security fixes, but there have been some bugfixes

[1] https://developers.yubico.com/yubioath-desktop/Release_Notes.html

@rissson
Copy link
Member Author

rissson commented Mar 19, 2020

Should I close this then?

@Mic92 Mic92 closed this Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rissson @Mic92