Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renderdoc: 1.6 -> 1.7 #82283

Merged
merged 1 commit into from Mar 11, 2020
Merged

renderdoc: 1.6 -> 1.7 #82283

merged 1 commit into from Mar 11, 2020

Conversation

jansol
Copy link
Contributor

@jansol jansol commented Mar 10, 2020

Motivation for this change
  • Upstream update
  • Added libglvnd to fix replaying OpenGL captures with renderdoccmd
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alyssais alyssais merged commit 711a869 into NixOS:master Mar 11, 2020
@alyssais
Copy link
Member

I added “Added libglvnd to fix replaying OpenGL captures with renderdoccmd” to the commit message. It’s good for that sort of detail to be included in the commit message as well as the PR body, because it’s more discoverable and likely to be around longer there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jansol @alyssais