Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "python: XStatic-Bootstrap: 3.3.7.1 -> 4.1.3.1" #82287

Closed
wants to merge 1 commit into from
Closed

Revert "python: XStatic-Bootstrap: 3.3.7.1 -> 4.1.3.1" #82287

wants to merge 1 commit into from

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Mar 10, 2020 •
edited

Motivation for this change

xstatic-bootstrap was bumped in #71893
This broke bepasty, because bepasty currently depends on xstatic-bootstrap < 4.
bepasty is the only package in nixpkgs that depends on xstatic-bootstrap.

There is an upstream issue here, but I don't think anyone is working on this right now.

Assuming this will get merged, it will also need a backport to 20.03.

In that case, it's also relevant to ZHF aka #80379.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @Lassulus (you use this, right?)
cc @FRidh (you committed this)
cc @ThomasWaldmann (upstream, will this change any time soon?)

@ofborg ofborg bot requested a review from makefu March 10, 2020 22:48
@makefu
Copy link
Contributor

makefu commented Mar 11, 2020

If required we could also split xstatic-bootstrap into xstatic-bootstrap3 and the latest package or override it just for bepasty.

@FRidh
Copy link
Member

FRidh commented Mar 12, 2020

Fixed with 73fa456

@FRidh FRidh closed this Mar 12, 2020
@ajs124 ajs124 deleted the fix/bepasty branch March 12, 2020 14:03
@ajs124
Copy link
Member Author

ajs124 commented Mar 12, 2020

@FRidh should I open a PR against 20.03 with 73fa456?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@makefu makefu Awaiting requested review from makefu

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ajs124 @makefu @FRidh