Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zoxide: init at 0.2.0 #82282

Merged
merged 2 commits into from Mar 11, 2020
Merged

zoxide: init at 0.2.0 #82282

merged 2 commits into from Mar 11, 2020

Conversation

ysndr
Copy link
Member

@ysndr ysndr commented Mar 10, 2020

Motivation for this change

I started using zoxide as an alternative to z and thought it would be nice to have it included in nixpkgs as well.
zoxide seems to be in a very early state though so I'd be fine to include it in my personal nur repo for some time until it proves stable enough to be added here.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ysndr ysndr mentioned this pull request Mar 10, 2020
Closed
@cole-h
Copy link
Member

cole-h commented Mar 10, 2020

Might want to wait until v0.2.0 is released, which will remove the fish/zsh/bash init scripts (in your preFixup) in favor of evaluating the output of a subcommand. It's currently over on the v0.2.0 branch for now.

@ysndr
Copy link
Member Author

ysndr commented Mar 10, 2020

Sure no need to rush that

@ajeetdsouza
Copy link
Contributor

zoxide v0.2.0 has been released!

@ysndr ysndr changed the title zoxide: init at 0.1.1 zoxide: init at 0.2.0 Mar 11, 2020
@ysndr
Copy link
Member Author

ysndr commented Mar 11, 2020

Updated to 0.2.0

cole-h
cole-h requested changes Mar 11, 2020
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor suggestion, then it's g2g!

pkgs/tools/misc/zoxide/default.nix Outdated Show resolved Hide resolved
@ysndr @cole-h
Remove unnecessary comment
a816a0a 
Co-Authored-By: Cole Helbling <cole.e.helbling@outlook.com>
@ysndr
Copy link
Member Author

ysndr commented Mar 11, 2020

Changed, thanks

cole-h
cole-h approved these changes Mar 11, 2020
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Binary runs as expected. Thanks!

[4 built, 2 copied (0.1 MiB), 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/82282
1 package built:
zoxide

@0xbe7a 0xbe7a mentioned this pull request Mar 11, 2020
Closed
10 tasks
@alyssais alyssais merged commit de892c2 into NixOS:master Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ysndr @cole-h @ajeetdsouza @alyssais