Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kitty: install man page on Darwin #82288

Merged
merged 1 commit into from Mar 11, 2020
Merged

Conversation

Luflosi
Copy link
Contributor

@Luflosi Luflosi commented Mar 10, 2020

Motivation for this change

On Linux the man page is already being built with setup.py linux-package and later copied to the correct location.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

On Linux the man page is already being built with `setup.py linux-package` and later copied to the correct location.
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Mar 10, 2020
@ofborg ofborg bot requested review from tex and Ma27 March 10, 2020 22:55
@veprbl
Copy link
Member

veprbl commented Mar 11, 2020

@GrahamcOfBorg build kitty

@Ma27 Ma27 merged commit 569d6d0 into NixOS:master Mar 11, 2020
@Luflosi Luflosi deleted the kitty-man-page-darwin branch March 11, 2020 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants