Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

passh: init at 2020-03-18 #82289

Merged
merged 1 commit into from Mar 23, 2020
Merged

passh: init at 2020-03-18 #82289

merged 1 commit into from Mar 23, 2020

Conversation

lovesegfault
Copy link
Member

Motivation for this change

I need this for an ugly hack and it's better than sshpass, i.e. it works.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lovesegfault
Copy link
Member Author

@GrahamcOfBorg eval

cole-h
cole-h requested changes Mar 11, 2020
View reviewed changes
pkgs/tools/networking/passh/default.nix Outdated Show resolved Hide resolved
cole-h
cole-h approved these changes Mar 11, 2020
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Binary displays help.

[3 built, 56 copied (245.7 MiB), 56.7 MiB DL]
https://github.com/NixOS/nixpkgs/pull/82289
1 package built:
passh

@lovesegfault lovesegfault changed the title passh: init at 2020-03-10 passh: init at 2019-07-04 Mar 11, 2020
@lovesegfault lovesegfault mentioned this pull request Mar 18, 2020
Closed
cole-h
cole-h requested changes Mar 19, 2020
View reviewed changes
pkgs/tools/networking/passh/default.nix Outdated Show resolved Hide resolved
@lovesegfault
Copy link
Member Author

@GrahamcOfBorg eval

@lovesegfault lovesegfault changed the title passh: init at 2019-07-04 passh: init at 2020-03-18 Mar 19, 2020
@lovesegfault
Copy link
Member Author

@GrahamcOfBorg eval passh

@lovesegfault
Copy link
Member Author

@grahamc @worldofpeace pinging for merge.

@worldofpeace worldofpeace merged commit 01fc385 into NixOS:master Mar 23, 2020
@lovesegfault lovesegfault deleted the passh-2020-03-10 branch March 23, 2020 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h approved these changes

@grahamc grahamc Awaiting requested review from grahamc

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lovesegfault @grahamc @cole-h @worldofpeace