Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brainworkshop: init at 2020-03-10 #82220

Closed
wants to merge 4 commits into from
Closed

brainworkshop: init at 2020-03-10 #82220

wants to merge 4 commits into from

Conversation

mt-caret
Copy link
Contributor

Motivation for this change

Adds brainworkshop, a Dual-n-back training application. Depends on #82219.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mt-caret mt-caret changed the title brainworkshop: init at 2020-01-20 brainworkshop: init at 2020-03-10 Mar 13, 2020
symphorien
symphorien reviewed Mar 15, 2020
View reviewed changes
pkgs/games/brainworkshop/default.nix
@@ -0,0 +1,37 @@
{ stdenv, lib, fetchFromGitHub, python36 }:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to hardcode python36 instead of just python3 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a workaround as python3 is 3.8 something, which breaks pyglet (https://github.com/pvcraven/arcade/issues/514)

@symphorien
Copy link
Member

the program starts correctly, but I can't hear any sound.

@mt-caret
Copy link
Contributor Author

Yeah; I'm digging through the code but I can't find why that's the case. The game is unplayable in its current state, and since I don't really have time to fix this right now, I guess this PR should be closed.

@mt-caret mt-caret closed this Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@symphorien symphorien symphorien left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mt-caret @symphorien