Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyglet: support ffmpeg libraries #82219

Merged
merged 1 commit into from Mar 24, 2020
Merged

pyglet: support ffmpeg libraries #82219

merged 1 commit into from Mar 24, 2020

Conversation

mt-caret
Copy link
Contributor

Motivation for this change

While pyglet may load a number of ffmpeg libraries, the paths are not hardcoded in
load_libraries so will fail when attempted. This fixes the issue.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mt-caret mt-caret mentioned this pull request Mar 10, 2020
Closed
10 tasks
jonringer
jonringer approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

[18 built (2 failed), 275 copied (5230.4 MiB), 1207.8 MiB DL]
error: build of '/nix/store/pi4407lc79p4gk84mjzp87sar3hfmhha-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/82219
1 package marked as broken and skipped:
python27Packages.baselines

3 package failed to build:
python37Packages.rl-coach python38Packages.baselines python38Packages.rl-coach

15 package built:
printrun python27Packages.gym python27Packages.pyglet python27Packages.pytmx python37Packages.baselines python37Packages.gym python37Packages.moderngl-window python37Packages.pyglet python37Packages.pytmx python37Packages.roboschool python38Packages.gym python38Packages.moderngl-window python38Packages.pyglet python38Packages.pytmx python38Packages.roboschool

ping me if there's no movement in a day or two

@mt-caret
Copy link
Contributor Author

ping @jonringer

@jonringer jonringer merged commit 248097c into NixOS:master Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mt-caret @jonringer