Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wxmaxima: 18.02.0 -> 20.02.4 #82323

Merged
merged 2 commits into from Mar 11, 2020
Merged

wxmaxima: 18.02.0 -> 20.02.4 #82323

merged 2 commits into from Mar 11, 2020

Conversation

xaverdh
Copy link
Contributor

@xaverdh xaverdh commented Mar 11, 2020

Motivation for this change

This updates wxmaxima to a recent release. The commit description is 18.02.0 -> 20.02.4, because in the last version bump (1c6a193), the version string was changed, but the hash was not. So the version currently in nixpkgs really is 18.02.0 (can also be seen from running wxmaxima --version).

Whats the policy for such changes? Should it be mentioned in the commit message?

Also the upstream source repository changed. The original repository at https://github.com/andrejv/wxmaxima redirects to https://github.com/wxMaxima-developers/wxmaxima.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from peti March 11, 2020 14:50
@veprbl
Copy link
Member

veprbl commented Mar 11, 2020

Should it be mentioned in the commit message?

If you do that, that won't hurt.

@veprbl veprbl merged commit 5ac085c into NixOS:master Mar 11, 2020
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Mar 11, 2020
@xaverdh @dtzWill
wxmaxima: 18.02.0 -> 20.02.4 (NixOS#82323)
1b6fe5b 
The commit description is 18.02.0 -> 20.02.4, because in the last version bump (1c6a193), the version string was changed, but the hash was not.

Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
(cherry picked from commit 5ac085c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xaverdh @veprbl