lenovo/thinkpad/t495: init from e495. #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etu
approved these changes
Mar 11, 2020
|
Please link to the profile in the README table |
The E495 and T495 are based on the same core Ryzen platform, so the E495 tweaks apply similarly to the T495. Tested on my own T495, works well.
|
@Mic92 added to README, and rebased. Thanks for the review, and sorry I missed the instructions! |
|
the linked issue also mentions adding: is that needed as well? |
|
Empirically no: it was off on my laptop before I started using nixos-hardware, and the machine booted to X11 and worked just fine. It means we miss out on newer Intel wifi/bluetooth firmware and AMD microcode, but it looks like the burned-in firmware and microcode that ships with the T495 is "good enough". I don't know what our policy is for that kind of thing? I think it's a good idea to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The E495 and T495 are based on the same core Ryzen platform, so the
E495 tweaks apply similarly to the T495.
Tested on my own T495, works well.