New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unbreak ats-format #82225
Closed
Closed
Unbreak ats-format #82225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update was generated by hackage2nix v2.15.0-21-ga388e13 from Hackage revision commercialhaskell/all-cabal-hashes@84ca5c6.
Current, the `cabal2nix` derivation contains both the executable, and a wrapper that adds `nix` and `nix-prefetch-scripts`, which are required for some features. However, when calling `callCabal2nix` to create a derivation from a cabal file at evaluation time, these features are not actually used, but the huge closure of `nix-prefetch-scripts` (which includes multiple vcs, as well as python and perl) still needs to be fetched. This commit splits cabal2nix into a lightweight version that is a standalone static binary (`cabal2nix-unwrapped`), and a wrapper that includes the proper dependencies in the path for full usage of the command line utility (`cabal2nix`). This commit also switches to the default ghc, to reduce the likelyhood of building a different ghc when calling `callCabal2nix`.
cabal2nix: split into a lightweight version and a wrapper
Fix zxcvbn-hs & zxcvbn-dvorak
This update was generated by hackage2nix v2.15.0-21-ga388e13 from Hackage revision commercialhaskell/all-cabal-hashes@4328a38.
The tests fail to compile because of a missing module but would otherwise be fine.
saltine: fix build by disabling tests
This update was generated by hackage2nix v2.15.0-21-ga388e13 from Hackage revision commercialhaskell/all-cabal-hashes@84be87e.
Remove snap from broken packages list
This update was generated by hackage2nix v2.15.0-21-ga388e13 from Hackage revision commercialhaskell/all-cabal-hashes@edb1ff5.
tests need a running mysql instance, so disable them
persistent-mysql: fix build
Unbreak haskell package ats-pkg
Wait why is it targeting master again 🤦♂️ |
Sorry for these PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)