Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbreak ats-format #82225

Closed
wants to merge 18 commits into from
Closed

Unbreak ats-format #82225

wants to merge 18 commits into from

Conversation

poscat0x04
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

peti and others added 18 commits March 7, 2020 02:31
This update was generated by hackage2nix v2.15.0-21-ga388e13 from Hackage revision
commercialhaskell/all-cabal-hashes@84ca5c6.
Current, the `cabal2nix` derivation contains both the executable, and a wrapper
that adds `nix` and `nix-prefetch-scripts`, which are required for some
features.

However, when calling `callCabal2nix` to create a derivation from a cabal file
at evaluation time,
these features are not actually used, but the huge closure of
`nix-prefetch-scripts` (which includes multiple vcs, as well as python and perl)
still needs to be fetched.

This commit splits cabal2nix into a lightweight version that is a standalone
static binary (`cabal2nix-unwrapped`), and a wrapper that includes the proper
dependencies in the path for full usage of the command line
utility (`cabal2nix`).

This commit also switches to the default ghc, to reduce the likelyhood of
building a different ghc when calling `callCabal2nix`.
cabal2nix: split into a lightweight version and a wrapper
This update was generated by hackage2nix v2.15.0-21-ga388e13 from Hackage revision
commercialhaskell/all-cabal-hashes@4328a38.
The tests fail to compile because of a missing module but would
otherwise be fine.
saltine: fix build by disabling tests
This update was generated by hackage2nix v2.15.0-21-ga388e13 from Hackage revision
commercialhaskell/all-cabal-hashes@84be87e.
This update was generated by hackage2nix v2.15.0-21-ga388e13 from Hackage revision
commercialhaskell/all-cabal-hashes@edb1ff5.
tests need a running mysql instance, so disable them
@poscat0x04
Copy link
Contributor Author

Wait why is it targeting master again 🤦‍♂️

@poscat0x04 poscat0x04 closed this Mar 10, 2020
@poscat0x04
Copy link
Contributor Author

poscat0x04 commented Mar 10, 2020

Sorry for these PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants