appimageTools: clean appimage-exec.sh options #82266
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
zimbatm
reviewed
Apr 7, 2020
| @@ -4,11 +4,15 @@ | |||
| , lib, runCommand }: | |||
|
|
|||
| rec { | |||
| appimage-exec = pkgs.substituteAll { | |||
| appimage-exec = with pkgs; substituteAll { | |||
There was a problem hiding this comment.
Suggested change
| appimage-exec = with pkgs; substituteAll { | |
| appimage-exec = substituteAll { |
It's best to be explicit about the dependencies and add it to the function parameters instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
As promise, i follow @tilpner review on #81833 .
I also simplify the script removing -w option and fix arguments passing that was missing when using the appimage in a wrapAppImage (i missed to test this use case).
I've integrate #60381 idea since no activity there, test it with minetime, zulip ... seems good.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)cc @Mic92