Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suitesparse: Enable parallel building #82260

Merged
merged 1 commit into from Mar 10, 2020
Merged

suitesparse: Enable parallel building #82260

merged 1 commit into from Mar 10, 2020

Conversation

knedlsepp
Copy link
Member

Motivation for this change

Building suitesparse currently takes around 45 minutes on hydra. This should considerably speed things up.
https://hydra.nixos.org/job/nixos/trunk-combined/nixpkgs.suitesparse.x86_64-linux#tabs-charts

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar
Copy link
Contributor

jtojnar commented Mar 10, 2020

I actually have a branch that does this plus many more. Will open a PR.

@ofborg ofborg bot requested a review from ttuegel March 10, 2020 16:32
@jtojnar
Copy link
Contributor

jtojnar commented Mar 10, 2020

Hmm, I do not have it in my cleanup branch. Must have accidentally removed. Though the main slowness comes from the GraphBLAS package build and my branch introduces a separate GraphBLAS so that should help too.

@jtojnar jtojnar merged commit 91c98f4 into NixOS:master Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@knedlsepp @jtojnar