Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

liberio: init at unstable-2019-12-11 #82259

Merged
merged 1 commit into from Mar 31, 2020
Merged

liberio: init at unstable-2019-12-11 #82259

merged 1 commit into from Mar 31, 2020

Conversation

doronbehar
Copy link
Contributor

Motivation for this change

An optional dependency for uhd.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@doronbehar doronbehar mentioned this pull request Mar 10, 2020
Closed
@doronbehar
Copy link
Contributor Author

@timokau I was glad to see my inbox filled with your activity here on Nixpkgs :). Trying to "catch the wave", perhaps you could take a look at this PR? It's a somewhat blocker for a bigger PR I'm planning to open.

@timokau
Copy link
Member

timokau commented Mar 31, 2020

Sure, already had it open in a tab ;) I was actually skimming through your contributions in particular, since I noticed you're doing good work both reviewing and contributing. Kind of a shame so much of it got stuck in the final stage.

timokau
timokau approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally I'd think twice about this since it doesn't seem to popular and hasn't been updated in a while, but since you're adding it as a dependency for an apparently widely used package this is fine.

@timokau timokau merged commit c6590b2 into NixOS:master Mar 31, 2020
@doronbehar
Copy link
Contributor Author

Thanks @timokau :).

@timokau
Copy link
Member

timokau commented Mar 31, 2020

You're welcome :)

If you think something is ready for merge now (either your own PR or something you reviewed), feel free to ping me.

@doronbehar
Copy link
Contributor Author

Cool :). Besides the PR for picard, I'm not sure if you are only "in to" merging PRs, but I'd be glad to get an opinion on #83296 . Thanks again.

@timokau timokau mentioned this pull request Mar 31, 2020
Closed
10 tasks
@doronbehar doronbehar deleted the package-liberio branch March 2, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timokau timokau timokau approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@doronbehar @timokau