Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlPackages.eigen: fix build on darwin #82299

Merged
merged 1 commit into from Mar 11, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Mar 11, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Mar 11, 2020
@marsam marsam mentioned this pull request Mar 11, 2020
10 tasks
@vbgl
Copy link
Contributor

vbgl commented Mar 11, 2020

@GrahamcOfBorg build ocamlPackages.eigen

@vbgl vbgl merged commit e2212ae into NixOS:master Mar 11, 2020
@marsam marsam deleted the fix-ocamlPackages.eigen-darwin branch March 11, 2020 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants