Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update elmPackages #82320

Closed
wants to merge 1 commit into from
Closed

Update elmPackages #82320

wants to merge 1 commit into from

Conversation

andys8
Copy link
Member

@andys8 andys8 commented Mar 11, 2020

Motivation for this change

Upgrade elm-language-server to 1.6.3.

Other elm packages updated:

  • elm-hot 1.1.4
  • elm-upgrade 0.19.8
  • elm-live 4.0.2
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @turboMaCk @razzeee @BrianHicks

turboMaCk
turboMaCk approved these changes Mar 11, 2020
View reviewed changes
Copy link
Member

@turboMaCk turboMaCk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • diff clear
  • All elmPackages build on NixOS

@domenkozar
Copy link
Member

Sorry missed this, could you rebase?

@andys8
Update elmPackages
5ca136c 
- elm-hot 1.1.4
- elm-upgrade 0.19.8
- elm-live 4.0.2
- elm-language-server 1.6.3
@andys8
Copy link
Member Author

andys8 commented Mar 18, 2020

The relevant changes were already merged with this commit.
baf37aa

I'll close the PR then :)

@andys8 andys8 closed this Mar 18, 2020
@turboMaCk
Copy link
Member

@andys8 Thanks for the PR anyway. I probably should have tag Domen since I don't have merge rights, sorry.

@andys8
Copy link
Member Author

andys8 commented Mar 18, 2020

No prob :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turboMaCk turboMaCk turboMaCk approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andys8 @domenkozar @turboMaCk