Fix missing default-policy.json in skopeo #82261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We started having issues with `pkgs.dockerTools.pullImage`, were it would fail with: ``` FATA[0000] Error loading trust policy: open /etc/containers/policy.json: no such file or directory ``` It turns out that since `skopeo` was bumped to `0.1.40`, it was accidentally no longer being built with a default policy. This may happen again, see containers/skopeo#787
|
Backported to 20.03 in 1cf2c15. |
|
And thank you for your contribution! 🎉 |
glensc
reviewed
Apr 14, 2020
| -X github.com/containers/skopeo/vendor/github.com/containers/image/signature.systemDefaultPolicyPath=${defaultPolicyFile} | ||
| -X github.com/containers/skopeo/vendor/github.com/containers/image/internal/tmpdir.unixTempDirForBigFiles=/tmp | ||
| -X github.com/containers/skopeo/vendor/github.com/containers/image/v5/signature.systemDefaultPolicyPath=${defaultPolicyFile} | ||
| -X github.com/containers/skopeo/vendor/github.com/containers/image/v5/internal/tmpdir.unixTempDirForBigFiles=/tmp |
There was a problem hiding this comment.
you probably do not want this override. default is /var/tmp anyway, and it's the path for big temp files according to FHS spec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
We started having issues with
pkgs.dockerTools.pullImage, were it would fail with:It turns out that since
skopeowas bumped to0.1.40, it was accidentally no longer being built with a default policy.Essentially the same change had to be done for homebrew's version of
skopeo: https://github.com/Homebrew/homebrew-core/pull/47766/filesThings done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)