New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
symmetrica: 2.0 -> 3.0.1 #82239
symmetrica: 2.0 -> 3.0.1 #82239
Conversation
9b480ad
to
b433985
Compare
Sorry, I lazily used |
b433985
to
6f76966
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise LGTM
license = licenses.isc; | ||
maintainers = with maintainers; [raskin timokau]; | ||
platforms = platforms.unix; | ||
homepage = https://gitlab.com/sagemath/symmetrica; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
homepage = https://gitlab.com/sagemath/symmetrica; | |
homepage = "https://gitlab.com/sagemath/symmetrica"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, fixed. Thanks!
This switches to the sagemath fork, since the original upstream is no longer maintained and sagemath has effectively maintained symmetrica through patches for a while now. The update fixes one bug in particular that has caused failures in the sagemath test suite: NixOS#81449 https://trac.sagemath.org/ticket/15312 https://trac.sagemath.org/ticket/29061 Regarding the licensing change: https://gitlab.com/sagemath/symmetrica/-/commit/7cf91b380078a4def28dd6bab2b4607e2346c650
6f76966
to
1a6b1fb
Compare
Fast-tracking this a bit since it unbreaks the sage package. We can always make changes or even revert in another PR. I hope you don't mind @7c6f434c. |
Motivation for this change
This switches to the sagemath fork, since the original upstream is no
longer maintained and sagemath has effectively maintained symmetrica
through patches for a while now. The update fixes one bug in particular
that has caused failures in the sagemath test suite:
#81449
https://trac.sagemath.org/ticket/15312
https://trac.sagemath.org/ticket/29061
Regarding the licensing change:
https://gitlab.com/sagemath/symmetrica/-/commit/7cf91b380078a4def28dd6bab2b4607e2346c650
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)