Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

symmetrica: 2.0 -> 3.0.1 #82239

Merged
merged 2 commits into from Mar 10, 2020
Merged

symmetrica: 2.0 -> 3.0.1 #82239

merged 2 commits into from Mar 10, 2020

Conversation

timokau
Copy link
Member

@timokau timokau commented Mar 10, 2020

Motivation for this change

This switches to the sagemath fork, since the original upstream is no
longer maintained and sagemath has effectively maintained symmetrica
through patches for a while now. The update fixes one bug in particular
that has caused failures in the sagemath test suite:

#81449
https://trac.sagemath.org/ticket/15312
https://trac.sagemath.org/ticket/29061

Regarding the licensing change:

https://gitlab.com/sagemath/symmetrica/-/commit/7cf91b380078a4def28dd6bab2b4607e2346c650

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau
Copy link
Member Author

timokau commented Mar 10, 2020

Sorry, I lazily used git rebase -i HEAD~30 to squash a few commits and it looks like github attributed all 30 commits to me. Should be fixed now.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

license = licenses.isc;
maintainers = with maintainers; [raskin timokau];
platforms = platforms.unix;
homepage = https://gitlab.com/sagemath/symmetrica;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
homepage = https://gitlab.com/sagemath/symmetrica;
homepage = "https://gitlab.com/sagemath/symmetrica";

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, fixed. Thanks!

This switches to the sagemath fork, since the original upstream is no
longer maintained and sagemath has effectively maintained symmetrica
through patches for a while now. The update fixes one bug in particular
that has caused failures in the sagemath test suite:

NixOS#81449
https://trac.sagemath.org/ticket/15312
https://trac.sagemath.org/ticket/29061

Regarding the licensing change:

https://gitlab.com/sagemath/symmetrica/-/commit/7cf91b380078a4def28dd6bab2b4607e2346c650
@timokau
Copy link
Member Author

timokau commented Mar 10, 2020

Fast-tracking this a bit since it unbreaks the sage package. We can always make changes or even revert in another PR. I hope you don't mind @7c6f434c.

@timokau timokau merged commit 6687d1e into NixOS:master Mar 10, 2020
@timokau timokau deleted the symmetrica-3.0.1 branch March 10, 2020 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants