New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disk-filltest: init at 0.8.1 #82242
disk-filltest: init at 0.8.1 #82242
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash into one commit. Commit message should be disk-filltest: init at 0.8.1
, just like the PR title :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, adding yourself to maintainer-list.nix
would be a separate commit. Sorry for not mentioning that before :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one change, this came up during review of another package :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good to me :) 👍
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
@GrahamcOfBorg build disk-filltest |
Motivation for this change
Add
disk-filltest
programm - a simple program which fills a path with random data and then rereads the files to check that the random sequence was correctly stored.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)