Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disk-filltest: init at 0.8.1 #82242

Merged
merged 2 commits into from May 24, 2020
Merged

disk-filltest: init at 0.8.1 #82242

merged 2 commits into from May 24, 2020

Conversation

caadar
Copy link
Contributor

@caadar caadar commented Mar 10, 2020

Motivation for this change

Add disk-filltest programm - a simple program which fills a path with random data and then rereads the files to check that the random sequence was correctly stored.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@caadar caadar changed the title add disk-filltest disk-filltest: init at 0.8.1 Mar 10, 2020
Copy link
Contributor

@puzzlewolf puzzlewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash into one commit. Commit message should be disk-filltest: init at 0.8.1, just like the PR title :)

pkgs/tools/system/disk-filltest/default.nix Outdated Show resolved Hide resolved
pkgs/tools/system/disk-filltest/default.nix Outdated Show resolved Hide resolved
pkgs/tools/system/disk-filltest/default.nix Show resolved Hide resolved
pkgs/tools/system/disk-filltest/default.nix Show resolved Hide resolved
Copy link
Contributor

@puzzlewolf puzzlewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, adding yourself to maintainer-list.nix would be a separate commit. Sorry for not mentioning that before :)

pkgs/tools/system/disk-filltest/default.nix Outdated Show resolved Hide resolved
Copy link
Contributor

@puzzlewolf puzzlewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one change, this came up during review of another package :)

pkgs/tools/system/disk-filltest/default.nix Outdated Show resolved Hide resolved
Copy link
Contributor

@puzzlewolf puzzlewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me :) 👍

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/161

@markuskowa
Copy link
Member

@GrahamcOfBorg build disk-filltest

@markuskowa markuskowa merged commit cc33cfe into NixOS:master May 24, 2020
@caadar caadar deleted the disk-filltest branch May 24, 2020 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants