Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

seabreeze: udev rules not installed #82303

Merged
merged 1 commit into from Mar 28, 2020
Merged

seabreeze: udev rules not installed #82303

merged 1 commit into from Mar 28, 2020

Conversation

sjmackenzie
Copy link
Contributor

fixes #82229

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Valodim
Copy link
Contributor

Valodim commented Mar 11, 2020 •
edited

This fixes the symptom, but I wonder about the underlying issue?

Following the documentation, and with a cursory glance over the implementation, I would have expected the package to work as-is.

(is there a policy for separate udev outputs, or udev rules in general? Or is it just "whatever works with existing code"?)

@matthewbauer
Copy link
Member

(is there a policy for separate udev outputs, or udev rules in general? Or is it just "whatever works with existing code"?)

I think we try to avoid custom outputs like this. (Although I see this being used in "moolticute" as well). Mostly because it can be confusing why you're not getting the udev rules by default.

In this case especially, udev is not really that big of a file, and doesn't pull in any big dependencies.

jonringer
jonringer approved these changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no noticeable difference in closure size:

[10:16:26] jon@jon-desktop /home/jon/projects/nixpkgs (master)
$ nix path-info -Sh ./result
/nix/store/rzmy40ncvwa4yy4bhz507jn6phh9r0gv-python3.7-seabreeze-0.6.0	 258.1M
[nix-shell:/home/jon/.cache/nixpkgs-review/pr-82303]$ nix path-info -Sh ./results/python37Packages.seabreeze
/nix/store/89wq8giy56pq8v1g0dp0ndmwjid9yz43-python3.7-seabreeze-0.6.0	 258.1M

@etu etu merged commit d0abce6 into NixOS:master Mar 28, 2020
@sjmackenzie sjmackenzie deleted the seabreeze branch March 28, 2020 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

seabreeze: udev rules not installed
5 participants
@sjmackenzie @Valodim @matthewbauer @jonringer @etu