[css-grid] Skip simplified layout if the Grid is dirty. #21151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 13, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1999224
branch
from
4f27a9a
to
e6c1eee
Compare
Bug report bisected to an improvement in the LayoutNG OOF cache. https://chromium-review.googlesource.com/c/chromium/src/+/1772524 There was a larger underlying issue that a LayoutGrid could have simplified layout performed, while having a non-existent grid. This manifested in an incorrect paint output. This patch simply disables simplified-layout whenever there is dirty grid. It doesn't seem the invalidation for this grid data-structure is optimal. Bug: 1040069 Change-Id: I347630f3fc5c330ae57b06219d1e32b6269177d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999224 Reviewed-by: Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#734856}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1999224
branch
from
e6c1eee
to
e98aee3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug report bisected to an improvement in the LayoutNG OOF cache.
https://chromium-review.googlesource.com/c/chromium/src/+/1772524
There was a larger underlying issue that a LayoutGrid could have
simplified layout performed, while having a non-existent grid.
This manifested in an incorrect paint output.
This patch simply disables simplified-layout whenever there is dirty
grid. It doesn't seem the invalidation for this grid data-structure
is optimal.
Bug: 1040069
Change-Id: I347630f3fc5c330ae57b06219d1e32b6269177d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999224
Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734856}