[css-pseudo] Implement LayoutNG normal markers as real pseudo-elements #21152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 13, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1985952
branch
3 times, most recently
from
813e38f
to
45ff490
Compare
Before this patch, list markers were only pseudo-elements when 'content' was different than 'normal'. Otherwise they were anonymous boxes. This makes them be pseudo-elements in that case too. This only affects LayoutNG, in legacy they continue being anonymous. BUG=457718 TEST=accessibility/aria-owns-sends-notification.html TEST=editing/selection/drag-to-contenteditable-iframe.html TEST=editing/selection/selectNode.html TEST=editing/selection/selectNodeContents.html TEST=external/wpt/css/css-pseudo/marker-computed-size.html TEST=external/wpt/css/css-pseudo/marker-content-014.html TEST=blink_unittests --gtest_filter=NGInlineCursorTest/NGInlineCursorTest.NextWithListItem/* TEST=blink_unittests --gtest_filter=ParameterizedTextPaintTimingDetectorTest.CapturingListMarkers/* TEST=content_browsertests --gtest_filter=All/DumpAccessibilityTreeTest.AccessibilityLi/* marker-content-014.html still fails in legacy since markers are not pseudo-elements yet. marker-computed-size.html also fails in legacy, and one of the subcases fails in LayoutNG since 'content: none' doesn't work yet in ::marker. fast/multicol/span/list-multi-column-crash.html now crashes with LayoutNGBlockFragmentation enabled due to bug 1040947. The crash was already happening with ::before and ::after, so it's expected. Change-Id: I51d9661f32b2e1c0c392c261853f8127b74136fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985952 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#731964}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1985952
branch
from
45ff490
to
10d1342
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, list markers were only pseudo-elements when 'content'
was different than 'normal'. Otherwise they were anonymous boxes.
This makes them be pseudo-elements in that case too.
This only affects LayoutNG, in legacy they continue being anonymous.
BUG=457718
TEST=accessibility/aria-owns-sends-notification.html
TEST=editing/selection/drag-to-contenteditable-iframe.html
TEST=editing/selection/selectNode.html
TEST=editing/selection/selectNodeContents.html
TEST=external/wpt/css/css-pseudo/marker-computed-size.html
TEST=external/wpt/css/css-pseudo/marker-content-014.html
TEST=blink_unittests --gtest_filter=NGInlineCursorTest/NGInlineCursorTest.NextWithListItem/*
TEST=blink_unittests --gtest_filter=ParameterizedTextPaintTimingDetectorTest.CapturingListMarkers/*
TEST=content_browsertests --gtest_filter=All/DumpAccessibilityTreeTest.AccessibilityLi/*
marker-content-014.html still fails in legacy since markers are not
pseudo-elements yet.
marker-computed-size.html also fails in legacy, and one of the subcases
fails in LayoutNG since 'content: none' doesn't work yet in ::marker.
fast/multicol/span/list-multi-column-crash.html now crashes with
LayoutNGBlockFragmentation enabled due to bug 1040947. The crash was
already happening with ::before and ::after, so it's expected.
Change-Id: I51d9661f32b2e1c0c392c261853f8127b74136fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985952
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731964}